Add flag to turn off non-blind cosmology messages #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picca will briefly become a dependency of vega (as I will discuss tomorrow), and we will be calling the Cosmo class from outside. Therefore we need a flag to turn-off the print statements done when there is no blinding, as they are not relevant when this is called from vega.
iprafols
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
I think we could even remove these messages. Honestly, with the blinding and the fact that they are printed in logs we seldom read, they have become close to useless. Maybe we can just leave the blinding / not blinding message and remove the others (but let's discuss this in the telecon this afternoon)
|
again, we need the coveralls fix to pass these tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picca will briefly become a dependency of Vega (as I will discuss tomorrow), and we will be calling the Cosmo class from outside. Therefore we need a flag to turn off the print statements done when there is no blinding, because they are not relevant when this is called from Vega.