Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read version directly from version file #1058

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

iprafols
Copy link
Collaborator

@iprafols iprafols commented Feb 6, 2024

This is a small change so that picca version is loaded from the _version.py file when loading the config. We discovered that depending on how picca was installed using pip the picca version saved in the .config.ini file might be bogus. This should not affect the git hash (also saved there).

Copy link
Contributor

@Waelthus Waelthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the change.
Do we know under which circumstances the incorrect version was reported? Is this something we might wanna store as well to detect e.g. inconsistent environments (assuming that causes the issue)?

@iprafols iprafols added this pull request to the merge queue Feb 6, 2024
Merged via the queue into master with commit 1965723 Feb 6, 2024
10 checks passed
@iprafols iprafols deleted the fix_loading_version branch February 6, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants