Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Average mean pk #1072

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Average mean pk #1072

merged 6 commits into from
Sep 16, 2024

Conversation

corentinravoux
Copy link
Contributor

For Y1 mocks, it is not possible to compute the average P1D of the 20 mocks (it hits maximal memory).
Implementation of an averaging of mean P1D + one script

Copy link
Contributor

@Waelthus Waelthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine with those changes if you are, basically it's just running the avg in the end for the combine plus some compat tests between input files.
If this isn't tested yet, maybe consider adding a test.

type=str,
default=None,
required=False,
help="String to glob all mean p1d to average",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in-dir would normally mean you put in a directory name and a predefined glob will be running within that dir, here it looks like a full glob-expression needs to be supplied, which I think is ok as well, but maybe should use a different name...

@iprafols iprafols added this pull request to the merge queue Sep 16, 2024
Merged via the queue into master with commit 99988ba Sep 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants