Fix deltas rebin #967
Merged
Fix deltas rebin #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iprafols
requested changes
Jan 17, 2023
py/picca/data.py
Outdated
| @@ -958,6 +958,7 @@ class Delta(QSO): | |||
| Neighbouring deltas/quasars | |||
| fname: string or None | |||
| String identifying Delta as part of a group | |||
| delta_log_lambda | |||
There was a problem hiding this comment.
add explanation and type
There was a problem hiding this comment.
Sorry I copied this line when it was already there.
|
just a minor change, otherwise it's fine |
|
I modified the hdul.close() position as well. |
iprafols
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation would fail if one of the first two pixels in the deltas field is masked.
Now, dwave (width of deltas) is read from the header of the deltas file, avoiding this problem.
It works with both ImageHDU and TableHDU formats, but only for linear deltas (as before).