Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple of very minor fixes #969

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Couple of very minor fixes #969

merged 2 commits into from
Jan 23, 2023

Conversation

iprafols
Copy link
Collaborator

No description provided.

Waelthus
Waelthus approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@Waelthus Waelthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new version looks fine for me, were there installation problems with the previous setup file? If yes, was the current release affected? Or has the git version in the description (or the line break) only been introduced after?

@iprafols
Copy link
Collaborator Author

Here I just added the missing f in the f-string so that the commit hash appears in the description of the code. Before it just printed the code

@iprafols iprafols merged commit 13bbbcd into master Jan 23, 2023
@iprafols iprafols deleted the fix_setup branch January 23, 2023 15:41
@Waelthus
Copy link
Contributor

ah, right. That makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waelthus Waelthus Waelthus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iprafols @Waelthus