True cont update #972
Merged
True cont update #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iprafols
reviewed
Feb 7, 2023
| @@ -123,7 +126,8 @@ def __parse_config(self, config): | |||
| self.raw_statistics_filename = config.get("raw statistics file") | |||
|
|
|||
| self.force_stack_delta_to_zero = config.getboolean("force stack delta to zero") | |||
|
|
|||
| self.use_splines=config.getboolean("use splines") | |||
There was a problem hiding this comment.
We should raise ExpectedFluxError when the different options are None if only to check that the default values are properly digested (it could not be the case if, for example, one is running from a notebook. I will add a commit to fix this
iprafols
approved these changes
Feb 7, 2023
|
It seems github actions have updated their version of pylint so I needed to fix a few minor things in some files for the pylint test to pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two options:
-- use splinesTo use mean continuum and var_lss from a spline fit saved in the raw statistics file.--recompute var lssTo use the var lss provided by the raw statistics file instead of the re-computed one. Set as True by default.Both additions motivated by the work with Andrea on CIV forest, as we were having issues getting a good true continuum CF.