Change LASTNIGHT for COADD_LASTNIGHT #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alxogm with your changes we are also checking for LASTNIGHT, what we would not be checking for is LAST_NIGHT. If some of the (old) catalogues will still have LASTNIGHT, then I'd keep it. Otherwise, instead of keeping LASTNIGHT, I would go straight to replacing it there (and in the other places in the code where it appears) by COADD_LASTNIGHT |
|
Hi @iprafols I'm not really sure which catalogs use what, so I think for now lets just check for COADD_LASTNIGHT as well, so we can close this issue and run on iron with the master branch. |
iprafols
approved these changes
Feb 17, 2023
|
Fine with me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final name for the Last night column in the per healpix catalog is COADD_LASTNIGHT. so I'm changing from LASTNIGHT to COADD_LASTNIGHT, this will require that other catalogs than the Himalayas one are updated, we can coordinate that with Abby and Lucas.
@iprafols @julienguy do you agree or do you prefer that we test for LASTNIGHT as well?