Fix data model #979
Merged
Fix data model #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #977 is already merged. I have merged master into fix_data_model so that those changes are updated here as well. Let me know when you are ready to merge this PR |
iprafols
requested changes
Mar 14, 2023
| @@ -350,8 +350,11 @@ def hdu_cont(self, results): | |||
| self.get_mean_cont(Forest.log_lambda_rest_frame_grid), | |||
| self.get_mean_cont_weight(Forest.log_lambda_rest_frame_grid), | |||
| ], | |||
| names=['loglam_rest', 'mean_cont', 'weight'], | |||
| names=['LOGLAM_REST', 'MEAN_CONT', 'WEIGHT'], | |||
| units=['log(Angstrom)', '10**-17 erg/(s cm2 Angstrom)', ''], | |||
There was a problem hiding this comment.
I'm thinking we should load this from the Data class or the Forest class, as different surveys might use different units for the flux
There was a problem hiding this comment.
I have added this. Only for fluxes. At first I did it also for wavelength, but I think it makes no sense to run picca in other units (for example BAL lines are defined in Angstroms, so we would need to write an unit converter)
iprafols
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This standardizes output fits files for image format.
I am waiting for #977 to be merged before adding tests, as both PR need to modify test files.