fix(account): Update keyring dependency to match Cosmos SDK
#2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjermundgaraba
requested review from
ilgooz,
lumtis,
jeronimoalbi,
aljo242,
tbruyelle and
fadeev
as code owners
|
I tested it in macOS with an M1 Pro and the accounts are created and deleted as expected from the Keychain Access app when using the |
jeronimoalbi
approved these changes
Jul 25, 2022
lumtis
approved these changes
Jul 26, 2022
This was referenced Jul 31, 2022
Closed
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
Co-authored-by: İlker G. Öztürk <[email protected]> Co-authored-by: Lucas Btd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2650
Original issue was also discussed on Discord: https://discord.com/channels/893126937067802685/905127580087234590/1000483556767846501
The main issue was:
The PR made to the Cosmos SDK was quite simple and after testing it with a couple of machines (M1 included) it seems like a safe update.
The PR: cosmos/cosmos-sdk#12576