Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converse UI should present 'offline settings' when queue is closed #49

Open
guusdk opened this issue Jan 15, 2021 · 2 comments
Open

Converse UI should present 'offline settings' when queue is closed #49

guusdk opened this issue Jan 15, 2021 · 2 comments

Comments

@guusdk
Copy link
Member

guusdk commented Jan 15, 2021

When a workgroup queue is not open (eg: no logged in agents), then the Converse UI should not show a functional chat button (the button that's used to start a new chat).

That button should either be removed, or be disabled somehow.

Note that ideally, the state of the button is dynamically adjusted, to ensure that, when the queue state changes, the button on the page (that has already been loaded) also does.
@guusdk
Copy link
Member Author

guusdk commented Jan 15, 2021

Confusingly, when the queue is closed, end-users clicking on the chat button appear to join a chatroom immediately. As I assume their messages will be lost, that's undesirable.

@guusdk guusdk mentioned this issue Jan 15, 2021
Closed
@guusdk
Copy link
Member Author

guusdk commented Jan 15, 2021

Falling back to a chatroom was added as a feature, not a bug, in https://github.com/guusdk/openfire-fastpath-plugin/blob/64d9a35e693ec7429d958dc1cc6d7e03738566ae/classes/ofmeet.js#L114

We've discussed this desired functionality in #48 and agreed to replace this with a new 'offline setting' instruction "offer to join chatroom" (#51)

@guusdk guusdk changed the title Converse UI should not show chat button (or disable it) when queue is closed Converse UI should present 'offline settings' when queue is closed Jan 15, 2021
guusdk added a commit to guusdk/openfire-fastpath-plugin that referenced this issue Jan 15, 2021
@guusdk
fixes igniterealtime#51: Add new offline setting: redirect to chatroom
b1affc5 
This introduces a new configurable 'offline setting': redirect to a chat room, adding this option to the database and the admin console.

The embedded converse client is modified to no longer hardcoded falling back to a chatroom, but to do this only when the offline settings instruct it to do so. This routine needs a lot more work (see igniterealtime#49).
guusdk added a commit that referenced this issue Apr 30, 2021
@guusdk
fixes #51: Add new offline setting: redirect to chatroom
a250223 
This introduces a new configurable 'offline setting': redirect to a chat room, adding this option to the database and the admin console.

The embedded converse client is modified to no longer hardcoded falling back to a chatroom, but to do this only when the offline settings instruct it to do so. This routine needs a lot more work (see #49).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guusdk