Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IgnOGRE2 support for ogre-next in Ubuntu Jammy #208

Closed
j-rivero opened this issue Mar 8, 2022 · 1 comment · Fixed by #224
Closed

IgnOGRE2 support for ogre-next in Ubuntu Jammy #208

j-rivero opened this issue Mar 8, 2022 · 1 comment · Fixed by #224
Assignees
Labels
enhancement New feature or request

Comments

@j-rivero
Copy link
Contributor

j-rivero commented Mar 8, 2022

Ubuntu jammy provides a libogre-next package that ships a custom CMake helper that can potentially work mostly on its own (see the patch used for ign-rendering code).

Desired behavior

IgnOGRE2 to support the Ubuntu Jammy ogre-next installation.

Alternatives considered

Until now, the alternative is to patch code to avoid IgnOGRE2 and use CMake diretly.

Implementation suggestion

Try to support the Ubuntu jammy versions transparently with the other installations existing out there.

Additional context

The root of the problem is the design of OGRE-Next to be an embedded piece of software inside other projects. This is hard to workaround and the origin of the IgnOGRE2 module.

@j-rivero j-rivero added the enhancement New feature or request label Mar 8, 2022
@j-rivero j-rivero self-assigned this Mar 8, 2022
@scpeters
Copy link
Member

scpeters commented Mar 9, 2022

something seems odd about the cmake version detection for libogre-next-dev. I just tried configuring cmake on a 22.04 container with a small patch to search for the OGRE-Next cmake package, and I see the following, noting the version: unknown:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index c0b903d0..a19804b0 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -97,7 +97,7 @@ endif()
 
 #--------------------------------------
 # Find OGRE2
-ign_find_package(IgnOGRE2 VERSION 2.2.0
+ign_find_package(OGRE-Next VERSION 2.2.0
     COMPONENTS HlmsPbs HlmsUnlit Overlay
     REQUIRED_BY ogre2
     PRIVATE_FOR ogre2)
CMake Warning at /usr/share/cmake/ignition-cmake2/cmake2/IgnUtils.cmake:189 (find_package):
  Could not find a configuration file for package "OGRE-Next" that is
  compatible with requested version "2.2.0".

  The following configuration files were considered but not accepted:

    /usr/lib/x86_64-linux-gnu/cmake/OGRE-Next/OGRE-NextConfig.cmake, version: unknown
    /lib/x86_64-linux-gnu/cmake/OGRE-Next/OGRE-NextConfig.cmake, version: unknown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants