-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ubuntu Jammy CI #577
Add Ubuntu Jammy CI #577
Conversation
Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #577 +/- ##
==================================================
- Coverage 54.36% 54.33% -0.04%
==================================================
Files 198 198
Lines 20157 20187 +30
==================================================
+ Hits 10958 10968 +10
- Misses 9199 9219 +20
Continue to review full report at Codecov.
|
this needs libogre-2.2-dev for jammy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI passes.
@j-rivero , did we get any version of Ogre 2.X upstreamed to Ubuntu? |
It took a while but yes https://packages.ubuntu.com/uk/jammy/libogre-next-dev Let me add that we still need IgnOGRE2 support for it, since it provides a custom CMake helper that can potentially work almost by its own, more info in gazebosim/gz-cmake#208 |
Specify different package names for ogre2.2 in distro-specific packages-*.apt files. Signed-off-by: Steve Peters <[email protected]>
I've moved the ogre2.2 package to distro-specific |
Jammy CI is not failing now, but it's also not finding the ogre-next package:
|
Patch adapted from gazebo-release/gz-rendering6-release#8 Signed-off-by: Steve Peters <[email protected]>
aa10c55
to
5370f67
Compare
I've adapted the patch by @j-rivero from https://github.com/ignition-release/ign-rendering6-release/pull/8/files#diff-93975c3b98779e4d395782d26e01fdfe517a184b37ed202723eb0c57ebcb6cfd in 5370f67 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
-- Checking for module 'OGRE-Next'
-- Found OGRE-Next, version 2.2.5
-- /usr/include/OGRE-Next/
-- /usr/include/OGRE-Next/
-- Found Ogre (2.2.5)
This PR was reverted with a commit directly to |
🦟 Bug fix
Part of gazebo-tooling/release-tools#566
Summary
Enable CI for Ubuntu 22.04 (Jammy)
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.