Allow model frames (__model__) to be used as joint parent or child #833
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The spec (http://sdformat.org/tutorials?tut=composition_proposal&cat=pose_semantics_docs-3-3-model-frame-references) says "For a model named
{name}
, model frames can be referenced by their name.{name}::__model__
is also valid, but {name} is preferred instead." libsdformat has supported using a model's{name}
in//joint/parent
and//joint/child
for a while, but it currently does not support{name}::__model__
. This PR rectifies that and also adds support for using just__model__
since that is a valid frame inside a model.Came up in PR review for #768: comment
Checklist
[ ] Updated documentation (as needed)[ ] Updated migration guide (as needed)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.