Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip pxr for sdformat #625

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Skip pxr for sdformat #625

merged 1 commit into from
Jan 19, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jan 19, 2022

Signed-off-by: ahcorde [email protected]

We are getting this warning in the CI, because we don't have pxr binaries available yet. This PR should remove this warning

CMake Warning at /usr/share/cmake/ignition-cmake2/cmake2/IgnConfigureBuild.cmake:55 (message):
   CONFIGURATION WARNINGS:
   -- Skipping component [usd]: Missing dependency [pxr].
      ^~~~~ Set SKIP_usd=true in cmake to suppress this warning.
   
Call Stack (most recent call first):
  CMakeLists.txt:121 (ign_configure_build)

Signed-off-by: ahcorde <[email protected]>
@ahcorde
Copy link
Collaborator Author

ahcorde commented Jan 19, 2022

Build Status

@ahcorde ahcorde merged commit 528a840 into master Jan 19, 2022
@ahcorde ahcorde deleted the ahcorde/skip_pxr branch January 19, 2022 22:27
@azeey
Copy link
Contributor

azeey commented Jan 20, 2022

This is causing a warning on current PRs targetting sdf12 (eg. gazebosim/sdformat#768). Are we going to make pxr available on CI before gazebosim/sdformat#817 is merged?

@chapulina
Copy link
Contributor

Is the plan to move on merging USD support without running it through Jenkins CI, but still running it through GitHub actions?

@ahcorde
Copy link
Collaborator Author

ahcorde commented Jan 20, 2022

The idea is to compile the usd module in Github Actions meanwhile we provide the binaries,

but if this is not the way I'm open to suggestions

@chapulina
Copy link
Contributor

but if this is not the way I'm open to suggestions

Sounds good to me, I just wanted to make sure I got it right. The important thing is to have at least some CI running in the process.

@scpeters
Copy link
Contributor

this is also causing a warning on sdf11. I think we should make this conditional on the sdformat major version

@scpeters
Copy link
Contributor

this is also causing a warning on sdf11. I think we should make this conditional on the sdformat major version

fix in #632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants