Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Attempt) Implement simple cycles bindings #803

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GenieTim
Copy link

@GenieTim GenieTim commented Nov 5, 2024

This is to indicate my progress implementing the cycle search in these Python bindings.

@GenieTim GenieTim marked this pull request as ready for review November 5, 2024 13:38
@GenieTim
Copy link
Author

GenieTim commented Nov 5, 2024

Not sure how to go about the submodule update... it is needed, but you probably want to do it separately / to a specific commit?

@szhorvat
Copy link
Member

szhorvat commented Nov 5, 2024

I see I don't need to give guidance, as you found your way :-)

I updated the C core on main before I realized that you did it here as well. Latest commit is okay for now.

P.S. @ntamas is in charge of the python-interface, but he's very busy right now. If you have any questions, I'll try to answer.

@szhorvat
Copy link
Member

szhorvat commented Nov 6, 2024

@ntamas, when you are dealing with this PR, be careful: it's been from a fork of the main branch, trying to force-push could wipe out our main branch.

@GenieTim Could you please close this and open a new PR from a branch named differently than main? I only realize now why I wasn't able to push to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants