Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_connection: rescue errors coming from CONNECT. #336

Merged
merged 1 commit into from
Mar 31, 2020
Merged

http_connection: rescue errors coming from CONNECT. #336

merged 1 commit into from
Mar 31, 2020

Conversation

crondaemon
Copy link
Contributor

Fix: #302.

igrigorik
igrigorik approved these changes Mar 31, 2020
View reviewed changes
Copy link
Owner

@igrigorik igrigorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@igrigorik igrigorik merged commit 1d1f82f into igrigorik:master Mar 31, 2020
@igrigorik
Copy link
Owner

Nice work, thank you!

@crondaemon crondaemon deleted the connect-rescue branch March 31, 2020 08:20
@crondaemon
Copy link
Contributor Author

Really fast, thanks. Will you release a new version soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igrigorik igrigorik igrigorik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy error callback missing for CONNECT
2 participants
@crondaemon @igrigorik