Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"classification" & ignore unknown ALB log fields #5

Merged
merged 3 commits into from
Oct 17, 2020

Conversation

PopeFelix
Copy link

At some point AWS added two more fields, "classification" and "classification_reason" to the ALB log format. This broke the parser, as
it assumed 27 fields, not 29. This adds support for those new fields as well as ignoring any additional fields (per AWS spec).

H/T to @jason-linthwaite for ignoring additional fields

At some point AWS added two more fields, "classification" and
"classification_reason" to the ALB log format. This broke the parser, as
it assumed 27 fields, not 29. This adds support for those new fields as
well as ignoring any additional fields (per AWS spec).
@kpeters-cbsi
Copy link

poke any motion on this?

@prettyClouds
Copy link

double poke this would be great to have...otherwise the parser just raises an exception on new log files.

@PopeFelix
Copy link
Author

PopeFelix commented Sep 30, 2020 via email

@igtm
Copy link
Owner

igtm commented Oct 17, 2020

Oh, I didn't notice..
thank you for your modification!

@igtm igtm merged commit 7142d18 into igtm:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants