-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small bugfix related to ensemble and min/max of terra #55
Conversation
Thanks, I see this happening to me as well. Might need a unit test added for the various ensemble uncertainty methods. Can you add this to the test_functions.R unit tests? (by the way, no need to make another branch for small bug fixes like this. Only for major changes/additions or so. Just commit them to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error occurs for me as well. All good
I can add a test, yes 👍 (P.S. I was just very confused by the error since the help file of terra actaully reads like there should be a |
No worries and much appreciate the fix (i did never calculate it even so did not notice :D ) |
* Update CITATION.cff * Update CITATION.cff * Smaller bug fixes and name sanitations * Update CITATION.cff * Prelunch commit. Some smaller fixes to make writing and loading models work * Update CITATION.cff * Pre-party commit. Similarity still not working yet. * Update CITATION.cff * Several updates, most notably improved 5 parameter Richards curve for offset calculations * Re-build README.md * Attempt to fix ci-error in tests * Small fix for tests * another attempt for ci fix * Update to version 0.0.5 (#53) (#54) * Update CITATION.cff * Update CITATION.cff * Smaller bug fixes and name sanitations * Update CITATION.cff * Prelunch commit. Some smaller fixes to make writing and loading models work * Update CITATION.cff * Pre-party commit. Similarity still not working yet. * Update CITATION.cff * Several updates, most notably improved 5 parameter Richards curve for offset calculations * Re-build README.md * Attempt to fix ci-error in tests * Small fix for tests * another attempt for ci fix --------- Co-authored-by: Martin-Jung <[email protected]> * Small bugfix related to ensemble and min/max of terra (#55) * Small bugfix related to ensemble and min/max of terra * Small bugfix related to ensemble and min/max of terra * Update tests for ensemble * Addition of MCP limits to `distribution` * Update CITATION.cff * Bug and documentation fixes * Update CITATION.cff * Started with implementation of check function #45 * Fix Missing link warning * Smaller documentation fixes * Update CITATION.cff * Warning and documentation fixes, adding aliases * Update CITATION.cff * Small hotfix for gh-pages and aliases * Update CITATION.cff * Small fix to validate * Fix two minor issues related to imports * Update CITATION.cff * Removed documentation whitespaces and minor conversion bug fix * Smaller fixes and implementation of #57 * Hotfix (:fire:) that pkgdown does not break * Small scenario addition and documentation fix. * Implementation of limiting function (#37) and minor bug fixes * 🐛 fix 😪 * Update CITATION.cff --------- Co-authored-by: Martin-Jung <[email protected]> Co-authored-by: Maximilian Hesselbarth <[email protected]> Co-authored-by: mhesselbarth <[email protected]>
Not sure if that's related to some strange
NAMESPACE
issue andterra
on my side, but the original code ondev
returnsError: 'max' is not an exported object from 'namespace:terra'
for me when usingensemble()
and the range as uncertainty meausre. However, runs fine ifmin()
andmax()
are not specified from theterra
NAMESPACE