-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous updates for 2023-W15 #476
Conversation
…replacing deprecated pkg_resources
This package has been deprecated and removed; see https://docs.codecov.com/docs/deprecated-uploader-migration-guide#python-uploader
Codecov Report
@@ Coverage Diff @@
## main #476 +/- ##
=====================================
Coverage 98.5% 98.5%
=====================================
Files 42 42
Lines 4486 4489 +3
=====================================
+ Hits 4422 4425 +3
Misses 64 64
|
Transfer flake8 settings to .flake8.
An updated pip is guaranteed by actions/setup-python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except for two minor things in pyproject.toml:
- The email supplied for the authors of our project doesn't exist anymore (as far as I know)
- Is there any reason to supply only
http
links for the repository and documentation instead ofhttps
?
Good catch. Which should we now prefer? I guess we could remove the e-mail altogether and instead give our own in the "maintainers" field…
No, thanks. I will correct this. |
I don't know if we have any other official address. But giving ours as the maintainers also sounds good. |
Okay, done! Please ✅ if we're good to go. |
Housekeeping items:
pkg_resources
withimportlib.metadata
.codecov
fromixmp[tests]
optional dependencies.ixmp[tests]
for any released version. All released versions of ixmp are now uninstallable. Per Codecov disappeared in PyPI? codecov/python-standard#31 (also 3, 4) this appears to have broken other code as well.pip install "ixmp @ git+https://github.com/iiasa/ixmp.git@main"
to work.How to review
Read the diff and note that the CI checks all pass.
PR checklist
Add or expand tests;coverage checks both ✅Add, expand, or update documentation.N/AUpdate release notes.N/A