-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid locking on failed operations #488
Conversation
Codecov Report
@@ Coverage Diff @@
## main #488 +/- ##
=====================================
Coverage 98.5% 98.5%
=====================================
Files 42 42
Lines 4506 4557 +51
=====================================
+ Hits 4442 4493 +51
Misses 64 64
|
d3dcb4e
to
4a0f835
Compare
8155a6c
to
4817168
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @khaeru. Small change requested for future developers.
I think the force push means I can't access my review to change to accept? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ok, was able to do a new review - thanks @khaeru ! |
The PR adds a new context manager
.utils.discard_on_error()
that can be used to avoid leaving scenarios in a locked state. This can occur when exceptions are raised and JDBCBackend is in use: an unclean exit means the database is left in a state that marks the scenario as "locked" for use by a particular user.Originally developed for iiasa/message_data#446.
How to review
PR checklist