Allow upgrading unmanaged local DBs #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed by @meksor, it would be good to allow initializing locals DBs. Currently, this is only possible for managed DBs. This PR also allows upgrading/initializing unmanaged local DBs. Though please check:
settings.manager_url
andsettings.secret_hs256
have default versions, so we could also write:which might safe us from writing a test to cover these lines specifically, but introduces slight overhead costs for running
ManagerConfig().__init__
even for unmanaged instances. Not sure which is preferable here.