Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described by @danielhuppmann, when setting a run as the default, ixmp4 accidentally also updates that info for all other runs with the same model/scenario combination.
This happens because the
set_as_default
function sets all the other runs tois_default = False
before settingTrue
on the singular subject run. The query is adjusted to only update rows which are actually not alreadyis_default = False
and I implemented a way to pause the event listeners to avoid setting that field on the previous default run as well.A repository can now pause the event listeners for a few lines like this:
Test is also adjusted to break if any of this ever happens again.
fixes #126