Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pandas 2.0 and 2.1 #80

Merged
merged 10 commits into from
Apr 17, 2024

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Apr 16, 2024

This PR implements a work-around for the changed API of pandas 2.2 for GroupBy.apply() and adds two tests for older pandas versions.

@danielhuppmann danielhuppmann self-assigned this Apr 16, 2024
@danielhuppmann danielhuppmann marked this pull request as ready for review April 17, 2024 04:19
Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One possible typo, otherwise looks good to me :)

ixmp4/data/db/iamc/timeseries/repository.py Outdated Show resolved Hide resolved
@glatterf42
Copy link
Member

I'm just now wondering: should these python 3.10 and 3.11 and different pandas and pyarrow tests really be part of every workflow? Or would it be enough to run our main pytest workflow with one configuration and have a separate legacy workflow for the rest?

@danielhuppmann
Copy link
Member Author

Yes, we can think of a better test-structure when also introducing a nightly test (only using the latest versions), but let's get the patch-release out so that I can get pyam operational again...

@danielhuppmann danielhuppmann merged commit 18fb1da into iiasa:main Apr 17, 2024
9 checks passed
@danielhuppmann danielhuppmann deleted the dependency/legacy-pandas branch April 17, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants