Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking credentials only when needed #9

Merged
merged 9 commits into from
Aug 30, 2023

Conversation

danielhuppmann
Copy link
Member

Working on the ixmp4-pyam integration, I noticed that ixmp4 immediately (tries to) connect to the IIASA-ScSe-Manager, resulting in a log output like
image

This can be confusing to pyam-only-users, so this PR changes the order so that the credentials are only loaded when needed.

@danielhuppmann
Copy link
Member Author

danielhuppmann commented Aug 30, 2023

One more change added: I removed the warning "No default credentials provided." because

  1. It is not necessary to provide credentials to use ixmp4, hence no warning necessary.
  2. There is currently no way (and no need?) to use non-default credentials anyway, hence the message is not necessary.

Note that there will still be a log message

ixmp4.conf.auth - INFO: Connecting to service anonymously and without credentials.

when connecting as anonymous user, which is sufficient for a normal user.

@meksor
Copy link
Contributor

meksor commented Aug 30, 2023

Sounds good, that was more the point of the message anyway! I think I might implement a way to use different credentials on the dev manager instance for example, hence the whole 'default'-and-such terminology.

@danielhuppmann danielhuppmann merged commit 8087b8d into iiasa:main Aug 30, 2023
4 checks passed
@danielhuppmann danielhuppmann deleted the config/lazy-load branch August 30, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants