-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce optimization variable #97
Open
glatterf42
wants to merge
20
commits into
main
Choose a base branch
from
include/optimization-variable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3264556
Introduce optimization.Variable
glatterf42 b5ecc7e
Fix references to DB filters in docs
glatterf42 9c99c9a
Streamline naming in tests
glatterf42 4bc348e
Make constrained_to_indexset optional for scalar Variables
glatterf42 6f81c34
Enable import of typing.Never on Python 3.10
glatterf42 ea009a1
Fix and test variable list and tabulate for specific runs
glatterf42 4a06b55
Include Run-side of relationship
glatterf42 35fbede
Fix name of Variable table
glatterf42 c6b38d9
Make indexset-creation a test utility
glatterf42 821db9f
Make new tests more efficient
glatterf42 fb5f43b
Incorporate changes from #110
glatterf42 45b90b7
Raise minimum pandas version to enable add_data upsert
glatterf42 4a4aa9e
Introduce variable.remove_data()
glatterf42 69eb973
Prefer None over Never for type hints
glatterf42 a5405c5
Remove superfluous session.add() for variable
glatterf42 c6ff088
Use pandas for updated add_data behaviour
glatterf42 8650a03
Adapt tests to current pandas-implementation
glatterf42 e84df74
Generalize UsageError for more optimization items
glatterf42 3e8d9ac
Use generalized UsageError for Table
glatterf42 5468b41
Use own errors for Variable
glatterf42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,144 @@ | ||
from datetime import datetime | ||
from typing import Any, ClassVar, Iterable | ||
|
||
import pandas as pd | ||
|
||
from ixmp4.core.base import BaseFacade, BaseModelFacade | ||
from ixmp4.data.abstract import Docs as DocsModel | ||
from ixmp4.data.abstract import OptimizationVariable as VariableModel | ||
from ixmp4.data.abstract import Run | ||
from ixmp4.data.abstract.optimization import Column | ||
|
||
|
||
class Variable(BaseModelFacade): | ||
_model: VariableModel | ||
NotFound: ClassVar = VariableModel.NotFound | ||
NotUnique: ClassVar = VariableModel.NotUnique | ||
|
||
@property | ||
def id(self) -> int: | ||
return self._model.id | ||
|
||
@property | ||
def name(self) -> str: | ||
return self._model.name | ||
|
||
@property | ||
def run_id(self) -> int: | ||
return self._model.run__id | ||
|
||
@property | ||
def data(self) -> dict[str, Any]: | ||
return self._model.data | ||
|
||
def add(self, data: dict[str, Any] | pd.DataFrame) -> None: | ||
"""Adds data to an existing Variable.""" | ||
self.backend.optimization.variables.add_data( | ||
variable_id=self._model.id, data=data | ||
) | ||
self._model.data = self.backend.optimization.variables.get( | ||
run_id=self._model.run__id, name=self._model.name | ||
).data | ||
|
||
def remove_data(self) -> None: | ||
"""Removes data from an existing Variable.""" | ||
self.backend.optimization.variables.remove_data(variable_id=self._model.id) | ||
self._model.data = self.backend.optimization.variables.get( | ||
run_id=self._model.run__id, name=self._model.name | ||
).data | ||
|
||
@property | ||
def levels(self) -> list: | ||
return self._model.data.get("levels", []) | ||
|
||
@property | ||
def marginals(self) -> list: | ||
return self._model.data.get("marginals", []) | ||
|
||
@property | ||
def constrained_to_indexsets(self) -> list[str]: | ||
return ( | ||
[column.indexset.name for column in self._model.columns] | ||
if self._model.columns | ||
else [] | ||
) | ||
|
||
@property | ||
def columns(self) -> list[Column] | None: | ||
return self._model.columns | ||
|
||
@property | ||
def created_at(self) -> datetime | None: | ||
return self._model.created_at | ||
|
||
@property | ||
def created_by(self) -> str | None: | ||
return self._model.created_by | ||
|
||
@property | ||
def docs(self): | ||
try: | ||
return self.backend.optimization.variables.docs.get(self.id).description | ||
except DocsModel.NotFound: | ||
return None | ||
|
||
@docs.setter | ||
def docs(self, description): | ||
if description is None: | ||
self.backend.optimization.variables.docs.delete(self.id) | ||
else: | ||
self.backend.optimization.variables.docs.set(self.id, description) | ||
|
||
@docs.deleter | ||
def docs(self): | ||
try: | ||
self.backend.optimization.variables.docs.delete(self.id) | ||
# TODO: silently failing | ||
except DocsModel.NotFound: | ||
return None | ||
|
||
def __str__(self) -> str: | ||
return f"<Variable {self.id} name={self.name}>" | ||
|
||
|
||
class VariableRepository(BaseFacade): | ||
_run: Run | ||
|
||
def __init__(self, _run: Run, *args, **kwargs) -> None: | ||
super().__init__(*args, **kwargs) | ||
self._run = _run | ||
|
||
def create( | ||
self, | ||
name: str, | ||
constrained_to_indexsets: str | list[str] | None = None, | ||
column_names: list[str] | None = None, | ||
) -> Variable: | ||
model = self.backend.optimization.variables.create( | ||
name=name, | ||
run_id=self._run.id, | ||
constrained_to_indexsets=constrained_to_indexsets, | ||
column_names=column_names, | ||
) | ||
return Variable(_backend=self.backend, _model=model) | ||
|
||
def get(self, name: str) -> Variable: | ||
model = self.backend.optimization.variables.get(run_id=self._run.id, name=name) | ||
return Variable(_backend=self.backend, _model=model) | ||
|
||
def list(self, name: str | None = None) -> Iterable[Variable]: | ||
variables = self.backend.optimization.variables.list( | ||
run_id=self._run.id, name=name | ||
) | ||
return [ | ||
Variable( | ||
_backend=self.backend, | ||
_model=i, | ||
) | ||
for i in variables | ||
] | ||
|
||
def tabulate(self, name: str | None = None) -> pd.DataFrame: | ||
return self.backend.optimization.variables.tabulate( | ||
run_id=self._run.id, name=name | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignoring this for now, more something for daniel i think