Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate reserve_margin() #211

Open
khaeru opened this issue Aug 1, 2024 · 0 comments
Open

Migrate reserve_margin() #211

khaeru opened this issue Aug 1, 2024 · 0 comments
Assignees
Labels
enh New features or functionality

Comments

@khaeru
Copy link
Member

khaeru commented Aug 1, 2024

In a review of #207, @glatterf42 noted that .model.workflow.solve()—that is, a standard "solve" workflow step for MESSAGEix-GLOBIOM workflows—uses a function message_data.scenario_generation.reserve_margin.res_marg.main() that is part of the closed-source message_data package.

For the moment, this step is optional and not tested, so that it lives in message_data is not a critical issue. But it limited the usability of the calling function to users who have access to message_data.

To resolve:

  1. Find a suitable location for this function in message_ix_models.
  2. Update its documentation.
  3. Add tests.
  4. Update usage in message_ix_models.
  5. Deprecate the version in message_data.
@khaeru khaeru added the enh New features or functionality label Aug 1, 2024
@khaeru khaeru self-assigned this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features or functionality
Projects
None yet
Development

No branches or pull requests

1 participant