Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport improvements for 2024-W31 #212

Merged
merged 8 commits into from
Aug 2, 2024
Merged

Transport improvements for 2024-W31 #212

merged 8 commits into from
Aug 2, 2024

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Aug 1, 2024

  • Investigate scale-1 values/pass-through of values for c=methanol. Next PR.

Housekeeping/code improvement:

  • Adjust the "transport" CI workflow to dispatch a run in message_data.
    • For security reasons, GitHub discourages allowing workflows in public repositories to run on private, self-hosted runners. This is because a malicious actor could open a PR that runs the workflow with modifications, accessing private data via the self-hosted runner.
    • This can be enabled in settings, but instead this PR takes a different approach.
    • The transport.yaml workflow is reduced to merely dispatch a workflow file that remains in message_data. That file in turn clones iiasa/message-ix-models (the specific branch/ref that is sending the dispatch) and runs the usual workflow.
  • Clean up .model.transport after migration #210
  • Adjust packaging so that .model.transport is included.
  • Migrate reserve_margin() #211 Next PR.

How to review

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation. N/A, mostly CI changes.
  • Update doc/whatsnew. N/A

@khaeru khaeru added enh New features or functionality transport MESSAGEix-Transport variant or transport in the base model labels Aug 1, 2024
@khaeru khaeru self-assigned this Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.8%. Comparing base (2fcae67) to head (de2446f).
Report is 311 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #212   +/-   ##
=====================================
  Coverage   58.8%   58.8%           
=====================================
  Files        194     194           
  Lines      15159   15159           
=====================================
  Hits        8922    8922           
  Misses      6237    6237           
Files with missing lines Coverage Δ
message_ix_models/model/transport/CHN_IND.py 30.3% <100.0%> (ø)
message_ix_models/model/transport/roadmap.py 56.0% <100.0%> (ø)
...e_ix_models/tests/model/transport/test_emission.py 100.0% <100.0%> (ø)

@khaeru khaeru force-pushed the transport/2024-W31 branch 11 times, most recently from 4081aa6 to 116f02e Compare August 2, 2024 10:56
@khaeru khaeru requested a review from glatterf42 August 2, 2024 11:42
Numpy requires that dtype comparisions use "==", but this is viewed as an error
by ruff.
- Ensure new modules from #207 are packaged.
- Exclude .github etc. from distributions (parallel to
  iiasa/message_ix).
Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing these issues so quickly! The one failing test is likely just flaky, so looks good to me :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I especially like the dispatch summary linking directly to the message_data run :)

@khaeru khaeru linked an issue Aug 2, 2024 that may be closed by this pull request
@khaeru khaeru merged commit 5270640 into main Aug 2, 2024
26 checks passed
@khaeru khaeru deleted the transport/2024-W31 branch August 2, 2024 12:48
@khaeru khaeru mentioned this pull request Aug 2, 2024
11 tasks
khaeru added a commit that referenced this pull request Aug 5, 2024
khaeru added a commit that referenced this pull request Aug 6, 2024
khaeru added a commit that referenced this pull request Aug 20, 2024
khaeru added a commit that referenced this pull request Aug 20, 2024
khaeru added a commit that referenced this pull request Aug 21, 2024
khaeru added a commit that referenced this pull request Sep 1, 2024
khaeru added a commit that referenced this pull request Sep 2, 2024
khaeru added a commit that referenced this pull request Sep 2, 2024
khaeru added a commit that referenced this pull request Sep 4, 2024
khaeru added a commit that referenced this pull request Sep 4, 2024
khaeru added a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features or functionality transport MESSAGEix-Transport variant or transport in the base model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up .model.transport after migration
2 participants