-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transport improvements for 2024-W31 #212
Conversation
Partly address #210.
- mypy 1.9.0 → 1.11.0 - ruff 0.3.2 → 0.5.5
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=====================================
Coverage 58.8% 58.8%
=====================================
Files 194 194
Lines 15159 15159
=====================================
Hits 8922 8922
Misses 6237 6237
|
4081aa6
to
116f02e
Compare
Numpy requires that dtype comparisions use "==", but this is viewed as an error by ruff.
- Ensure new modules from #207 are packaged. - Exclude .github etc. from distributions (parallel to iiasa/message_ix).
116f02e
to
de2446f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing these issues so quickly! The one failing test is likely just flaky, so looks good to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I especially like the dispatch summary linking directly to the message_data run :)
InvestigateNext PR.scale-1
values/pass-through of values for c=methanol.Housekeeping/code improvement:
.model.transport
after migration #210MigrateNext PR.reserve_margin()
#211How to review
PR checklist
Add, expand, or update documentation.N/A, mostly CI changes.Update doc/whatsnew.N/A