Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test & improve perfomance in .tools.add_year #494

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Jul 18, 2021

Most (137 of 187) untested lines in message_ix are in .tools.add_year: https://codecov.io/gh/iiasa/message_ix/tree/master/message_ix/tools/add_year

This PR adds tests for this code, but also reimplements some internal methods for better performance.

Partially addresses #433.

How to review

To be added.

PR checklist

  • Complete code
    • Remove usage of pandas.DataFrame.append(), which was removed in pandas 2.0.0.
  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes.

@khaeru khaeru added the enh New features & functionality label Jul 18, 2021
@khaeru khaeru self-assigned this Jul 18, 2021
@codecov
Copy link

codecov bot commented Jul 18, 2021

Codecov Report

Merging #494 (7a3d2ba) into main (a824be9) will increase coverage by 0.6%.
The diff coverage is 92.0%.

@@           Coverage Diff           @@
##            main    #494     +/-   ##
=======================================
+ Coverage   94.4%   95.0%   +0.6%     
=======================================
  Files         43      43             
  Lines       3432    3482     +50     
=======================================
+ Hits        3241    3310     +69     
+ Misses       191     172     -19     
Impacted Files Coverage Δ
message_ix/tools/add_year/__init__.py 72.8% <88.8%> (+6.6%) ⬆️
message_ix/tests/tools/test_add_year.py 96.9% <100.0%> (+1.1%) ⬆️

@glatterf42
Copy link
Member

Filtering out commits that were included in #703 already.

@khaeru khaeru mentioned this pull request May 22, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants