Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exception in add_year #579

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Raise exception in add_year #579

wants to merge 2 commits into from

Conversation

gidden
Copy link
Member

@gidden gidden commented Apr 6, 2022

Required: write a single sentence that describes the changes made by this PR.

This PR raises an exception at the start of add_year()

How to review

Required: describe specific things that reviewer(s) must do, in order to ensure that the PR achieves its goal.
If no review is required, write “No review:” and describe why.

Confirm that tests still pass and advise on any issues that arise as a result of non-passage

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes.

@gidden
Copy link
Member Author

gidden commented Apr 6, 2022

Please advise on whether to run black here which results in a large diff

@LauWien
Copy link
Contributor

LauWien commented Apr 6, 2022

Please advise on whether to run black here which results in a large diff

Hm, possible we can create a new PR where we run black in the whole repository and then rebase this PR once merged? @khaeru what do you think?

@LauWien
Copy link
Contributor

LauWien commented Apr 6, 2022

Please advise on whether to run black here which results in a large diff

I just see your branch is out of date with master, I guess a rebase will do the trick.

@gidden
Copy link
Member Author

gidden commented Apr 6, 2022

ah hah - let me rebase and cherry-pick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants