Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mamba solver instead of conda solver #715

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented May 30, 2023

Since we pinned the message-ix version to help the conda workflow pass, we need to keep this version number up-to-date.

The above was true in principle, but did not solve our CI conda-forge test problems. As suggested in conda/conda/issues/12741, replacing the conda solver with the mamba solver did. This even allows us to remove the message_ix version pin entirely.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅

@glatterf42 glatterf42 added the ci Continuous integration label May 30, 2023
@glatterf42 glatterf42 self-assigned this May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #715 (ff25045) into main (4663f1d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #715   +/-   ##
=====================================
  Coverage   94.4%   94.4%           
=====================================
  Files         43      43           
  Lines       3448    3448           
=====================================
  Hits        3257    3257           
  Misses       191     191           

@glatterf42 glatterf42 requested a review from khaeru May 30, 2023 12:07
Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  1. Uncomment these lines:
    # Uncomment to debug
    # pull_request:
    # branches: [ main ]
  2. Commit with a message like "TEMPORARY …"
  3. Push.
  4. Confirm that the workflow passes with this change, e.g. by leaving a comment or updating the PR description like "Note here that the jobs all pass with this change."
  5. Drop the temporary commit from the branch, e.g. git reset --hard HEAD~1 && git push --force.

((5) isn't necessary if the PR will be squash-merged.)

@glatterf42
Copy link
Member Author

glatterf42 commented Jun 6, 2023

The tests all pass using the mamba solver. Thus, I will

  • Change the description of this PR
  • Reset all commits and introduce just the changes we want to keep
  • Open a new issue to deal with the cache saving problem

@glatterf42 glatterf42 changed the title Bump message_ix version in conda workflow Use mamba solver instead of conda solver Jun 6, 2023
* Remove pin of message-ix version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants