Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dac tutorial add tech #810

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Dac tutorial add tech #810

wants to merge 14 commits into from

Conversation

gidden
Copy link
Member

@gidden gidden commented Mar 28, 2024

This is a fresh PR where we will implement DACCS related tutorials. It depends on iiasa/message-ix-models#158 where additional features for implementing DACCS in scenarios are developed.

This supercedes #793 and #806

FYI @ywpratama

Required: write a single sentence that describes the changes made by this PR.

How to review

Required: describe specific things that reviewer(s) must do, in order to ensure that the PR achieves its goal.
If no review is required, write “No review:” and describe why.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0.58480% with 170 lines in your changes are missing coverage. Please review.

Project coverage is 91.8%. Comparing base (27cd54e) to head (96c5cd1).

❗ Current head 96c5cd1 differs from pull request most recent head 67181b2. Consider uploading reports for the commit 67181b2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #810     +/-   ##
=======================================
- Coverage   95.4%   91.8%   -3.6%     
=======================================
  Files         46      47      +1     
  Lines       4354    4524    +170     
=======================================
  Hits        4156    4156             
- Misses       198     368    +170     
Files Coverage Δ
message_ix/util/tutorial.py 100.0% <100.0%> (ø)
message_ix/tools/add_tech/__init__.py 0.0% <0.0%> (ø)

@glatterf42
Copy link
Member

Hi @gidden, please clarify for me: I thought we wanted to have the tutorials be part of message-ix-models. Was this decision revised? Should I still set up a docs page etc for tutorials in message-ix-models?

@gidden
Copy link
Member Author

gidden commented Mar 29, 2024

Hey @glatterf42 - good questions. Yes, in reviewing this PR and related work with @ywpratama yesterday, we realized that his add_dac() functionality was more generic and could be applied at a high level repo (similar to add_years() here). That is at least the proposal for now, which we can discuss once the PR is finalized.

So in short, no need to add tutorials page yet to message-ix-models

@gidden
Copy link
Member Author

gidden commented May 8, 2024

@glatterf42 and @ywpratama - this PR now has the content added to it that is expected. It would be useful if the two of you could sit down and discuss how to best add relevant tests for this so it can be merged.

@ywpratama there should be already available documentation for how to pass the code quality checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants