Add poetry and test GH action #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phackstock
requested changes
Aug 29, 2024
There was a problem hiding this comment.
Looks very good to me. Two suggestions in line below.
One more thing that I would add is the __version__ attribute which most python packages implement. You can take a look at https://github.com/IAMconsortium/nomenclature/blob/18c0b1228058a30bec9898caa90df362f98ebecf/nomenclature/__init__.py#L31 how nomenclature does it.
phackstock
reviewed
Sep 2, 2024
Co-authored-by: Philip Hackstock <[email protected]>
phackstock
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Good to be merged with one exception.
You need to explicitly set the __version__ attribute, like we do in nomenclature https://github.com/IAMconsortium/nomenclature/blob/9055d38aa2ce8d91b0d171d8c004615d6ecff58a/nomenclature/__init__.py#L31.
Once you add that you can merge this PR, no need for another review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14, closes #13, closes #4, closes #5
Adds poetry to project and sets up GitHub Action using poetry and pytest