Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CITATION.cff and update README #36

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Add CITATION.cff and update README #36

merged 6 commits into from
Sep 4, 2024

Conversation

dc-almeida
Copy link
Collaborator

Closes #32, closes #33

@dc-almeida dc-almeida added the enhancement New feature or request label Sep 3, 2024
@dc-almeida dc-almeida added this to the Release 1.0 milestone Sep 3, 2024
@dc-almeida dc-almeida self-assigned this Sep 3, 2024
Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small, change to the README, then it should be good to be merged.

README.md Outdated
```

Each Region object consists of five attributes: a NUTS code (e.g.: AT127), a country
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use an enumeration of the five attributes, either bulleted or numbered:

Each Region object consists of five attributes:

  • a NUTS code (e.g.: AT127)
  • a country code
  • a label ...
  • ...

@dc-almeida dc-almeida merged commit a42c974 into main Sep 4, 2024
5 checks passed
@dc-almeida dc-almeida deleted the dev branch September 4, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Citation.cff for Zenodo integration Check README documentation before publishing
2 participants