Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issues 1134 #1430

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Fix Issues 1134 #1430

merged 1 commit into from
Feb 16, 2017

Conversation

cololi
Copy link
Contributor

@cololi cololi commented Feb 14, 2017

Fix Google Analytics can’t use

@ivan-nginx
Copy link
Collaborator

Google analytics work's fine on both HTTP and HTTPS protocols without scheme.

@cololi
Copy link
Contributor Author

cololi commented Feb 15, 2017

I think it's essential to add HTTPS as it's certainly the future and tendency.

@ivan-nginx
Copy link
Collaborator

@Kirito269 google want HTTPS only on sites who's need this HTTPS (shops, user passes, etc.).
On static blogs HTTPS may be, but don't need by google instantly.

I see my HTTP site and GA work fine. But, there is some error and i will rechecked it. But i think what GA script no need scheme by this fix.

@iissnan iissnan merged commit c53bcfe into iissnan:master Feb 16, 2017
@iissnan
Copy link
Owner

iissnan commented Feb 16, 2017

It is reasonable to add https scheme to the uri of the tracking script, since Google now only serve it over https. Actually there would be a 307 redirection if using http scheme, but I didn't figure out why it does not work.

habren pushed a commit to habren/hexo-theme-next that referenced this pull request Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants