-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the user to override the whole configuration #1861
Conversation
scripts/merge-configs.js
Outdated
if ( data.next.override ) | ||
hexo.theme.config = data.next | ||
else | ||
merge(hexo.theme.config, data.next) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected '{' and instead saw 'merge'.
Missing semicolon.
scripts/merge-configs.js
Outdated
data && data.next && merge(hexo.theme.config, data.next); | ||
if ( data && data.next ) { | ||
if ( data.next.override ) | ||
hexo.theme.config = data.next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected '{' and instead saw 'hexo'.
Missing semicolon.
Add override flag documentation
I just thinking about this a few days ago and you already do it. Great addition! I really appreciate this. And thank you very much to do NexT better! |
Thank you for bringing this so fast alive :) Best regards! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number(s): #1860
What is the new behavior?
This PR adds a flag in the
_data/next.yml
configuration that allows the user to override the theme configuration. Useful if you don't want to inherit default set by the theme already.How to use?
In NexT
_config.yml
:Does this PR introduce a breaking change?