Added cross layers checks to cross-links plugin #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you mean by cross-layer checking? Do you mean if any of my own drawn links intersect? |
|
@mxxcon Exactly! During the design of a little op, we made a mistake with a link, because of two portals next to each other. With this small feature, it should be possible to minimize these kind of human errors. |
dodomorandi
changed the title
* When an intersection involving a field is detected, a polygon is drawn instead of a polyline * Added an array containing pairs of layers. Now it is possible to track the intersections between layers * testCrossLayers was not run inside onMapDataRefreshEnd
This should make the map more readable when a multilayer is crossed.
|
I fixed a couple of issues. We are testing for further bugs, but now it seems to work flawlessly... This is how it is now, without filling color: |
dodomorandi
changed the title
75 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a simple cross-layers checking. This should be helpful when designing big ops and there are many portals next to each other. This should avoid human errors.
EDIT: now that @mxxcon made me think about that, why not adding a screenshot?
