enable click in portalinfo on smartphone #1125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
only disable click of imgpreview in the portal info page on smartphones |
75 tasks
|
@HubertZhang Still relevant? I do not understand why enable the click event if the information appears on the hover event |
|
You have to click to make information appears on mobiles...
Alexander Danilov <[email protected]>于2018年11月23日 周五16:06写道：
… @HubertZhang <https://github.com/HubertZhang> Still relevant? I do not
understand why enable the click event if the information appears on the
hover event
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1125 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFOeGl7yGNMgI8bUwRd6PdiUvtGNtv9bks5ux6yGgaJpZM4Jvpht>
.
|
|
Yes, and when clicked, the hover event is triggered.
|
modos189
added a commit
to IITC-CE/ingress-intel-total-conversion
that referenced
this pull request
Nov 27, 2018
iitc-project/ingress-intel-total-conversion#1125 #2 When pressed, the hover event is triggered, so I do not see the need, but the change will not be superfluous
But it popups anyway, without any changes. And more, this PR leads to error: IITC-CE/ingress-intel-total-conversion#41 |
|
@modos189 Sorry for late reply. I just tested on my iPhone and clicking the mod detail wont trigger the detail popup to be shown. I think we should not disable all click event in that portal detail, but only the image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now mods detail would popup on smartphone