Add HOOK to "userLocation" plugin #1177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an 'pluginUserLocation' hook. Events: - 'setup' is fired when the marker is initialized. Returns the marker location; - 'onLocationChange' is fired when the marker location is changed. Returns the new marker location; - 'onOrientationChange' is fired when the marker direction is change. Returns the new marker direction (deg);
nhamer
reviewed
Jan 20, 2017
| @@ -152,6 +160,9 @@ window.plugin.userLocation.onOrientationChange = function(direction) { | |||
| "transform": "rotate(" + direction + "deg)", | |||
| "webkitTransform": "rotate(" + direction + "deg)" | |||
| }); | |||
|
|
|||
| // HOOK: fired when the marker direction is changed | |||
| window.runHooks('pluginUserLocation', {event: 'onOrientationChange', data:{ direction:direction }}); | |||
There was a problem hiding this comment.
Can you add data: latlng here for parameter consistency?
There was a problem hiding this comment.
Yes I can, but this function has not the latlng data, I'll must get coordinates from a layer of plugin e.g. window.plugin.userLocation.marker.getLatLng(); Leafletjs getLatLng() method
There was a problem hiding this comment.
Or I can create a window.plugin.userLocation.user object with inside latlng and direction.
The data are updated in this object, the users/plugins can get the data from the object and the hook only serves to notify when the data are changed.
There was a problem hiding this comment.
That sounds sensible - although I'd pass the userLocation.user argument as an argument
- add an object contains user location and direction; - add a simple function to get the user data (loc and dir); - when the hook is fired return the user object;
nhamer
approved these changes
Jan 21, 2017
75 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an 'pluginUserLocation' hook, so other plugins can use the user coordinates.
Events:
location;
Returns the new marker location;
Returns the new marker direction (deg);