-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update player-tracker.user.js #1196
Conversation
To be able to see the nicknames of players under their labels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great idea, but you have committed the expanded user.js, not the pre-built one. You have a bunch of crud in here that should not be committed. Please fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also consider using the standard team colors, not blue and green, and clean out the dead/commented code.
I clean out the dead/commented code. what's about last commit ? |
Could you post a screenshot of what it looks like? |
Is there an option to turn off this layer? In a busy area I suspect this might be unusable. |
I'm sorry I haven't tested it yet, but with similar types of changes, I have seen problems when the map gets moved or pound or zoomed, or the person in question moves on the map. Are those cases handled correctly in this one? |
I have not encountered such a problem when the map gets moved or zoomed |
ES6 isn't supported by PhantomJS (let declaration)
It used in many screenshot bots, and other projects. |
To be able to see the nicknames of players under their labels