Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update player-tracker.user.js #1196

Closed
wants to merge 4 commits into from
Closed

Update player-tracker.user.js #1196

wants to merge 4 commits into from

Conversation

kddmitry
Copy link

@kddmitry kddmitry commented Mar 3, 2017

To be able to see the nicknames of players under their labels

To be able to see the nicknames of players under their labels
Copy link
Contributor

@pleasantone pleasantone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea, but you have committed the expanded user.js, not the pre-built one. You have a bunch of crud in here that should not be committed. Please fix it.

Copy link
Contributor

@pleasantone pleasantone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also consider using the standard team colors, not blue and green, and clean out the dead/commented code.

@kddmitry
Copy link
Author

kddmitry commented Mar 3, 2017

I clean out the dead/commented code. what's about last commit ?

@mxxcon
Copy link

mxxcon commented Mar 14, 2017

Could you post a screenshot of what it looks like?

@kddmitry
Copy link
Author

Here:
example 1
example 2
example 3

@mxxcon
Copy link

mxxcon commented Mar 15, 2017

Is there an option to turn off this layer? In a busy area I suspect this might be unusable.

@pleasantone
Copy link
Contributor

I'm sorry I haven't tested it yet, but with similar types of changes, I have seen problems when the map gets moved or pound or zoomed, or the person in question moves on the map. Are those cases handled correctly in this one?

@kddmitry
Copy link
Author

@mxxcon

Is there an option to turn off this layer? In a busy area I suspect this might be unusable.

Yep, it looks like this :
example 1

@pleasantone

I'm sorry I haven't tested it yet, but with similar types of changes, I have seen problems when the map gets moved or pound or zoomed, or the person in question moves on the map. Are those cases handled correctly in this one?

I have not encountered such a problem when the map gets moved or zoomed

@okded
Copy link

okded commented Sep 1, 2017

ES6 isn't supported by PhantomJS (let declaration)

(Unexpected token: name (iColor) (line: 433, col: 8))

It used in many screenshot bots, and other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants