Bookmark util functions #994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nested folders would go a long way to improving bookmark handling as well |
|
Yes you're right, but I guess that might need a major refactor of that plugin. I'm not sure I want to that though cause I'm not sure it will be heated :/ (a simple pull request as #993 has not heared response yet, and I don't want to put time into something that will not have any effect anyway) |
Open
|
Updated, so this can be easily merged |
75 tasks
|
Closing this for cleanup purposes of my open PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished implementing #980:
Created utility functions (and docs) for the bookmarks plugins:
added methods:
Also used these methods in the addElement and removeElement method, so no duplicate code was crated.