Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete hap_protocol coverage #332

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Mar 6, 2021

  • Improves handling of client closing connection cleanly

@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #332 (ccf8ba4) into dev (87e9f4d) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #332      +/-   ##
==========================================
+ Coverage   90.43%   90.57%   +0.14%     
==========================================
  Files          19       19              
  Lines        1881     1889       +8     
  Branches      217      217              
==========================================
+ Hits         1701     1711      +10     
+ Misses        135      134       -1     
+ Partials       45       44       -1     
Impacted Files Coverage Δ
pyhap/hap_protocol.py 100.00% <100.00%> (+1.62%) ⬆️

@bdraco bdraco marked this pull request as ready for review March 6, 2021 07:01
@bdraco
Copy link
Contributor Author

bdraco commented Mar 6, 2021

@ikalchev That should be it for a while. At some point I'd like to add full coverage for pair and pair verify but thats for another day.

Tested and should be good to go for release.

@ikalchev ikalchev merged commit 220a5e7 into ikalchev:dev Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants