Ensure HTTP 200 status is sent when get_characteristics has no failures #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #337 +/- ##
==========================================
+ Coverage 90.57% 90.60% +0.02%
==========================================
Files 19 19
Lines 1889 1894 +5
Branches 217 220 +3
==========================================
+ Hits 1711 1716 +5
Misses 134 134
Partials 44 44
|
bdraco
force-pushed
the
fix_http_code_get_success
branch
2 times, most recently
from
9e1a8ec
to
6909c16
Compare
Previously we always sent a multi-status of 207 even when there were no failures. HomeKit expects a HTTP 200 response when there are no failures, and for status to be not be set in the 100% success state.
bdraco
force-pushed
the
fix_http_code_get_success
branch
from
6909c16
to
372dbf4
Compare
|
@ikalchev Can we get a release with this one when you have a free moment? |
|
Sure, will merge and release tomorrow. |
|
Thank you 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we always sent a multi-status of 207 even when
there were no failures. HomeKit expects a HTTP 200 response
when there are no failures, and for status to be not
be set in the 100% success state.
This change drastically reduces the amount of polling that
the iOS device does because it no longer schedules a retry
based on the unexpected 207 which translates into a meaningful
improvement in battery life.