-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce payload sizes by adding support for short UUIDs and compact json #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #345 +/- ##
==========================================
+ Coverage 90.66% 90.81% +0.14%
==========================================
Files 19 19
Lines 1897 1917 +20
Branches 220 224 +4
==========================================
+ Hits 1720 1741 +21
Misses 133 133
+ Partials 44 43 -1
|
Apple defined uuids should be reduced to their short form to reduce the payloads
This does quite a bit to reduce payload sizes and improve performance since the encrypted payloads are much smaller. |
@ikalchev Can we get a release with this for this week's Home Assistant beta? Thanks! |
bdraco
force-pushed
the
short_uuids
branch
2 times, most recently
from
May 25, 2021 10:09
668205d
to
a19f4ce
Compare
bdraco
changed the title
Add support for short UUIDs
Reduce payload sizes by add supporting for short UUIDs and compact json
May 25, 2021
bdraco
changed the title
Reduce payload sizes by add supporting for short UUIDs and compact json
Reduce payload sizes by add support for short UUIDs and compact json
May 25, 2021
bdraco
changed the title
Reduce payload sizes by add support for short UUIDs and compact json
Reduce payload sizes by adding support for short UUIDs and compact json
May 25, 2021
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/accessories
payloads sizes are now reduced by ~40%+ with:Apple defined uuids should be reduced to their short form to reduce the payloads
description
(optional) is only included in the payload if it has been customizedcompact json
fixes events not being utf-8 encoded
This solved another case of iOS getting stuck updating when the bridge has many devices