Fix handling of explict close #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for next_event was not correct for explict closes as https://github.com/python-hyper/h11/blob/a2c68948accadc3876dffcf979d98002e4a4ed27/h11/_connection.py#L445 will only return h11.ConnectionClosed as an object and not a type
Codecov Report
@@ Coverage Diff @@
## dev #467 +/- ##
==========================================
- Coverage 92.63% 92.55% -0.08%
==========================================
Files 20 20
Lines 2267 2271 +4
Branches 279 279
==========================================
+ Hits 2100 2102 +2
- Misses 123 124 +1
- Partials 44 45 +1
|
bdraco
commented
Oct 22, 2023
| @@ -246,27 +246,33 @@ def _process_one_event(self) -> bool: | |||
| logger.debug( | |||
| "%s (%s): h11 Event: %s", self.peername, self.handler.client_uuid, event | |||
| ) | |||
| if event in (h11.NEED_DATA, h11.ConnectionClosed): | |||
There was a problem hiding this comment.
This bug was missed because there was no explicit test and it looked like it was covered because we did match on NEED_DATA
|
Thanks. It would probably be good to get a patch release for this since it can leave around connections otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for next_event was not correct for explict closes as https://github.com/python-hyper/h11/blob/a2c68948accadc3876dffcf979d98002e4a4ed27/h11/_connection.py#L445
will only return h11.ConnectionClosed as an object and not a type