Acc Driver: Should_notify #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I recall correctly this made iOS unhappy (unsupported acc or unpaired), but I need to double check this. Have you tried if this change works as expected with, say, (mock) temperature sensor or a bulb? |
|
I didn't noticed any issues with the accessories I've tested including the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently came across an issue on the Home Assistant Github page: home-assistant/core#13345
A user has two iPads and if he executes a command on one the state doesn't change on the second one. I believe that can be fixed with setting
should_notify=Truein theset_characteristicsmethod ofaccessory_driver. However I don't know if there are any reasons why you choose to set it in the first place.