Consistently use strings for Spec keys #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisandreae
force-pushed
the
consistent-string-keys
branch
from
de1fd57
to
4879aab
Compare
As it turns out we'd inconsistently used symbols (in #parse) and strings (largely from iknow_view_models) interchangeably, which was not only ugly but also prevented correct `merge!`ing. The string convention is used in many more places, so settle on that.
chrisandreae
force-pushed
the
consistent-string-keys
branch
from
4879aab
to
a70e71e
Compare
thefloweringash
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out we'd inconsistently used symbols (in #parse) and strings (largely from iknow_view_models) interchangeably, which was not only ugly but also prevented correct
merge!ing. The string convention is used in many more places, so settle on that.