-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zig 12 Support #38
base: master
Are you sure you want to change the base?
Zig 12 Support #38
Conversation
Co-authored-by: Nigel Baillie <[email protected]>
Three other examples fixed here. Feel free to add that into this pr. |
can we still publish a apk in the Play Store? |
It seems that you need to build an aab file instead, this would be a good addition to the repository. |
Yeah I acctually wrote a new build system that creates an aab, the process is very simmilar but with some extra steps and required downloads (they arent inlcuded in the sdk or buildtools for some reason) |
This PR claims to give this project support for Zig 12, however, you cannot build this with even zig 11, because as of zig 11, std.build and std.build.Builder have been combined into std.Build, and there is no std.build. How are you compiling this, are you using an older version of zig's std? |
I wrote some changes to get it to build for me. The only thing I have left is to get it to strip the binaries for .ReleaseSmall. I don't know yet how to do that. |
I'm using |
The removal of |
But in the change notes for 0.11.0, they list:
https://ziglang.org/download/0.11.0/release-notes.html#Rename-Types-and-Functions |
Deprecated doesn't imply removed immediately https://github.com/ziglang/zig/blob/e19219fa0e0a563dfda4a5f00737e0aadd7ca44e/lib/std/std.zig#L198 |
Ok, my problem was that the version of std that I got from here: https://ziglang.org/download/0.11.0/zig-0.11.0.tar.xz does not contain the same code for std as that snapshot. It seems that this was added in after 0.11.0. That was my misunderstanding |
build alias has removed. see: ziglang/zig@142471f#diff-79f63a2ce591380c4ec317daf5a0566972135f67b1b39c7173ddbe765d5446a0 Suggestion (based on andrewrk nasm fork): const build_rename = std.SemanticVersion.parse("0.12.0-dev.1377+3fc6fc681") catch unreachable;
const Build = if (builtin.zig_version.order(build_rename).compare(.lt)) std.build else std.Build;
pub fn build(b: *Build) void { ... } |
Follow up of PR #36 tested with zig 0.12.0-dev.1746+19af8aac8
Here is @desttinghim, I did fixed the sign step, I was runing before the zipalign but now everything is runing in the order they supose to (you can check useing
--summary all
)Edit: I only fixed the egl sample
Edit2: Had to add bindings for OpenSLES because of many dependencies loop in the translate-c sample