Improved declaration structure #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR phpredis#1602 we decided to use unsigned short for storing RedisSock->port but in previous release I reverted that change. In this PR I changed signatire of redis_sock_create to prevent unneccecary convertion of types.
Adds some tests to protect against regressions when connecting to unix sockets and high ports.
Update docs for Zstd
Create FUNDING.yml
Add helper function to check liveness of connection after getting it from the pool. Send `AUTH` before `PING` if necessary in pipeline.
* It should be impossible to cause a buffer overrun with this format string but use the safer version anyway. * Make the phpredis challenge string searchable and add 32 bits of entropy since it's theoretically possible that two machines would generate the same `tv_sec` + `tv_usec` string.
Add helper function to check liveness of connection after getting it from the pool. Send `AUTH` before `PING` if necessary in pipeline.
* It should be impossible to cause a buffer overrun with this format string but use the safer version anyway. * Make the phpredis challenge string searchable and add 32 bits of entropy since it's theoretically possible that two machines would generate the same `tv_sec` + `tv_usec` string.
These methods accept a single argument, not two arguments. (cluster_cmd_get_slot accepts one argument)
Fix typos detected by codespell
Fix proto comments for host_port in RedisCluster
package.xml has a minimum version of 7.0 PHP 8.0 will probably be out in around a year.
Remove "PHP Version 5" comment section
I our test suite we were only checking if an exception was an instance of `RedisException` and marking the test 'SKIPPED' if not. This was masking a failure in the RedisCluster test for testMultiExec by showing it as skipped when it was actually throwing an exception (not being able to execute the MULTI across the cluster).
Fix phpredis#1956 bad type usage on 32-bit
Add GET option to SET command
Add IDLE argument to XPENDING command
Add CLIENT INFO subcommand.
…elop_simple_strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move declaration methods around so that they don't need to sit inside the header file