Allow deriving Default, and using #[default] variants #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhenrymantilla
approved these changes
Aug 16, 2021
num_enum_derive/src/lib.rs
Outdated
| NumEnumVariantAttributeItem::Alternatives(alternatives) => { | ||
| attr_spans.alternatives.push(alternatives.span()); | ||
| alternative_values | ||
| .extend(alternatives.expressions.iter().cloned()); |
There was a problem hiding this comment.
Potential micro-optimization: I suspect the .iter() at line 280 can be removed to iterate by value so that here we can also directly yield full ownership of alternatives.expressions to .extend() 🙂
num_enum_derive/src/lib.rs
Outdated
| let enum_info = parse_macro_input!(stream as EnumInfo); | ||
|
|
||
| let default_ident: Ident = match enum_info.default() { | ||
| Some(ident) => ident.clone(), |
There was a problem hiding this comment.
Suggested change
| Some(ident) => ident.clone(), | |
| Some(ident) => ident, |
|
|
||
| TokenStream::from(quote! { | ||
| impl ::core::default::Default for #name { | ||
| fn default() -> Self { |
There was a problem hiding this comment.
Suggested change
| fn default() -> Self { | |
| #[inline] | |
| fn default() -> Self { |
rust-lang/rust#87517 started standardising `#[default]` as an attribute on enum variants, support it compatibly identically to `#[num_enum(default)]`.
illicitonion
force-pushed
the
standard-default
branch
from
f4fabf9
to
deb11d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#87517 started standardising
#[default]as an attribute on enum variants, support it compatiblyidentically to
#[num_enum(default)].Also, allow deriving
::core::default::Defaultwith thenum_enum::Defaultderive untilderive_default_enumstabilises.Fixes #56