Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Confetti #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added Confetti #24

wants to merge 2 commits into from

Conversation

jierm2
Copy link

@jierm2 jierm2 commented May 4, 2023

  • Once all the mosaics have been generated, the homepage will feature confetti effects.

wadefagen
wadefagen requested changes May 4, 2023
View reviewed changes
Copy link
Member

@wadefagen wadefagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running this branch, the frontend no longer works. I left a comment at the first error, but make sure everything fully works in the PR. :)

static/js/1989.js Outdated
@@ -49,12 +50,14 @@ let doSubmit = function () {
body: data,
})
.then((response) => response.json())
.then((json) => {
.then((json) => {r
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This results in an error in the frontend when running this JavaScript code.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed it! sorry for making a stupid mistake

  • Once all the mosaics have been generated, the homepage will feature party confetti effects.
  • If the user doesn't upload the base image or makes another bad request, the page will feature sad face confetti effects.

@jierm2 jierm2 requested a review from wadefagen May 4, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wadefagen wadefagen Awaiting requested review from wadefagen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jierm2 @wadefagen